[edk2] [Patch 0/2] Check Media status before starting DHCP process.

Jiaxin Wu posted 2 patches 6 years, 4 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 13 ++++++++++++-
NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c                     | 14 +++++++++++++-
2 files changed, 25 insertions(+), 2 deletions(-)
[edk2] [Patch 0/2] Check Media status before starting DHCP process.
Posted by Jiaxin Wu 6 years, 4 months ago
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Karunakar P <karunakarp@amiindia.co.in>
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>

Jiaxin Wu (2):
  MdeModulePkg/Dhcp4Dxe: Check Media status before starting DHCP
    process.
  NetworkPkg/Dhcp6Dxe: Check Media status before starting DHCP process.

 MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 13 ++++++++++++-
 NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c                     | 14 +++++++++++++-
 2 files changed, 25 insertions(+), 2 deletions(-)

-- 
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/2] Check Media status before starting DHCP process.
Posted by Laszlo Ersek 6 years, 4 months ago
Hi Jiaxin,

On 12/01/17 09:38, Jiaxin Wu wrote:
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Karunakar P <karunakarp@amiindia.co.in>
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> 
> Jiaxin Wu (2):
>   MdeModulePkg/Dhcp4Dxe: Check Media status before starting DHCP
>     process.
>   NetworkPkg/Dhcp6Dxe: Check Media status before starting DHCP process.
> 
>  MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 13 ++++++++++++-
>  NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c                     | 14 +++++++++++++-
>  2 files changed, 25 insertions(+), 2 deletions(-)
> 

I assume this is to address
<https://bugzilla.tianocore.org/show_bug.cgi?id=804>. If that's the
case, can you please add the BZ reference to the commit messages?

(No need to repost just because of this.)

Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/2] Check Media status before starting DHCP process.
Posted by Wu, Jiaxin 6 years, 4 months ago
Thanks Laszlo, I will update the messages before committing the patches. 



> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Friday, December 1, 2017 7:53 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Karunakar P <karunakarp@amiindia.co.in>;
> Fu, Siyuan <siyuan.fu@intel.com>
> Subject: Re: [edk2] [Patch 0/2] Check Media status before starting DHCP
> process.
> 
> Hi Jiaxin,
> 
> On 12/01/17 09:38, Jiaxin Wu wrote:
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Karunakar P <karunakarp@amiindia.co.in>
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> >
> > Jiaxin Wu (2):
> >   MdeModulePkg/Dhcp4Dxe: Check Media status before starting DHCP
> >     process.
> >   NetworkPkg/Dhcp6Dxe: Check Media status before starting DHCP process.
> >
> >  MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 13
> ++++++++++++-
> >  NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c                     | 14 +++++++++++++-
> >  2 files changed, 25 insertions(+), 2 deletions(-)
> >
> 
> I assume this is to address
> <https://bugzilla.tianocore.org/show_bug.cgi?id=804>. If that's the
> case, can you please add the BZ reference to the commit messages?
> 
> (No need to repost just because of this.)
> 
> Thanks!
> Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/2] Check Media status before starting DHCP process.
Posted by Fu, Siyuan 6 years, 4 months ago
Hi, Jiaxin

If the network cable is plug-in after this error returned, will the IP/DHCP driver restart DHCP process to request an address automatically?


BestRegards
Fu Siyuan


> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Friday, December 1, 2017 4:39 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>;
> Karunakar P <karunakarp@amiindia.co.in>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [Patch 0/2] Check Media status before starting DHCP process.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Karunakar P <karunakarp@amiindia.co.in>
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> 
> Jiaxin Wu (2):
>   MdeModulePkg/Dhcp4Dxe: Check Media status before starting DHCP
>     process.
>   NetworkPkg/Dhcp6Dxe: Check Media status before starting DHCP process.
> 
>  MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 13 ++++++++++++-
>  NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c                     | 14 +++++++++++++-
>  2 files changed, 25 insertions(+), 2 deletions(-)
> 
> --
> 1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 0/2] Check Media status before starting DHCP process.
Posted by Wu, Jiaxin 6 years, 4 months ago
Yes, IP driver will restart the DHCP process automatically when the user plug-in the cable. 

Thanks,
Jiaxin

> -----Original Message-----
> From: Fu, Siyuan
> Sent: Monday, December 4, 2017 9:54 AM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Karunakar P <karunakarp@amiindia.co.in>
> Subject: RE: [Patch 0/2] Check Media status before starting DHCP process.
> 
> Hi, Jiaxin
> 
> If the network cable is plug-in after this error returned, will the IP/DHCP
> driver restart DHCP process to request an address automatically?
> 
> 
> BestRegards
> Fu Siyuan
> 
> 
> > -----Original Message-----
> > From: Wu, Jiaxin
> > Sent: Friday, December 1, 2017 4:39 PM
> > To: edk2-devel@lists.01.org
> > Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>;
> > Karunakar P <karunakarp@amiindia.co.in>; Wu, Jiaxin
> <jiaxin.wu@intel.com>
> > Subject: [Patch 0/2] Check Media status before starting DHCP process.
> >
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Karunakar P <karunakarp@amiindia.co.in>
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> >
> > Jiaxin Wu (2):
> >   MdeModulePkg/Dhcp4Dxe: Check Media status before starting DHCP
> >     process.
> >   NetworkPkg/Dhcp6Dxe: Check Media status before starting DHCP process.
> >
> >  MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 13
> ++++++++++++-
> >  NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c                     | 14 +++++++++++++-
> >  2 files changed, 25 insertions(+), 2 deletions(-)
> >
> > --
> > 1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel