From nobody Fri May 3 05:38:20 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1502860843194488.33557317426335; Tue, 15 Aug 2017 22:20:43 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7501B21E2DA6C; Tue, 15 Aug 2017 22:18:15 -0700 (PDT) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 166FB21E2DA45 for ; Tue, 15 Aug 2017 22:18:14 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 15 Aug 2017 22:20:39 -0700 Received: from ydong10-win10.ccr.corp.intel.com ([10.239.158.51]) by orsmga005.jf.intel.com with ESMTP; 15 Aug 2017 22:20:38 -0700 X-Original-To: edk2-devel@lists.01.org X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,381,1498546800"; d="scan'208";a="138015930" From: Eric Dong To: edk2-devel@lists.01.org Date: Wed, 16 Aug 2017 13:20:36 +0800 Message-Id: <1502860836-14164-1-git-send-email-eric.dong@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 Subject: [edk2] [Patch v4] UefiCpuPkg RegisterCpuFeaturesLib: Fix buffer pointer error usage. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ruiyu Ni , Shao Ming , Michael D , Kinney@ml01.01.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Current code allocate buffer for the pointer which later get value from PCD database. but current code error use "=3D" for this case. Use AllocateCopyPool instead to fix it. V2 enhanced to directly use AllocateCopyPool to get the PCD value. V3 enhanced to avoid using local temp variable. V4 enhanced to keep the functions to get the pcd values. Cc: Ruiyu Ni Cc: Shao Ming Cc: Kinney, Michael D Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong Reviewed-by: Kinney, Michael D --- .../RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 16 ++++++++----= ---- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitializ= e.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c index 474aea3..b8f76f1 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c @@ -60,13 +60,13 @@ GetSupportPcds ( VOID ) { - UINTN BitMaskSize; UINT8 *SupportBitMask; =20 - BitMaskSize =3D PcdGetSize (PcdCpuFeaturesSupport); - SupportBitMask =3D AllocateZeroPool (BitMaskSize); + SupportBitMask =3D AllocateCopyPool ( + PcdGetSize (PcdCpuFeaturesSupport),=20 + PcdGetPtr (PcdCpuFeaturesSupport) + ); ASSERT (SupportBitMask !=3D NULL); - SupportBitMask =3D (UINT8 *) PcdGetPtr (PcdCpuFeaturesSupport); =20 return SupportBitMask; } @@ -81,13 +81,13 @@ GetConfigurationPcds ( VOID ) { - UINTN BitMaskSize; UINT8 *SupportBitMask; =20 - BitMaskSize =3D PcdGetSize (PcdCpuFeaturesUserConfiguration); - SupportBitMask =3D AllocateZeroPool (BitMaskSize); + SupportBitMask =3D AllocateCopyPool ( + PcdGetSize (PcdCpuFeaturesUserConfiguration),=20 + PcdGetPtr (PcdCpuFeaturesUserConfiguration) + ); ASSERT (SupportBitMask !=3D NULL); - SupportBitMask =3D (UINT8 *) PcdGetPtr (PcdCpuFeaturesUserConfiguration); =20 return SupportBitMask; } --=20 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel