From nobody Sun May 5 00:00:56 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1502776774881310.4922933462102; Mon, 14 Aug 2017 22:59:34 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7304A21E11D92; Mon, 14 Aug 2017 22:57:08 -0700 (PDT) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6A68721DFC89E for ; Mon, 14 Aug 2017 22:57:07 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 14 Aug 2017 22:59:31 -0700 Received: from ydong10-win10.ccr.corp.intel.com ([10.239.158.51]) by orsmga005.jf.intel.com with ESMTP; 14 Aug 2017 22:59:30 -0700 X-Original-To: edk2-devel@lists.01.org X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,376,1498546800"; d="scan'208";a="137509018" From: Eric Dong To: edk2-devel@lists.01.org Date: Tue, 15 Aug 2017 13:59:28 +0800 Message-Id: <1502776768-12720-1-git-send-email-eric.dong@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 Subject: [edk2] [Patch v2] UefiCpuPkg RegisterCpuFeaturesLib: Fix buffer pointer error usage. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ruiyu Ni , Shao Ming MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Current code allocate buffer for the pointer which later get value from PCD database. but current code error use "=3D" for this case. Use AllocateCopyPool instead to fix it. V2 enhanced to directly use AllocateCopyPool to get the PCD value. Cc: Ruiyu Ni Cc: Shao Ming Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 6 ++--= -- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitializ= e.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c index 474aea3..b3b2d84 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c @@ -64,9 +64,8 @@ GetSupportPcds ( UINT8 *SupportBitMask; =20 BitMaskSize =3D PcdGetSize (PcdCpuFeaturesSupport); - SupportBitMask =3D AllocateZeroPool (BitMaskSize); + SupportBitMask =3D AllocateCopyPool (BitMaskSize, (UINT8 *) PcdGetPtr (P= cdCpuFeaturesSupport)); ASSERT (SupportBitMask !=3D NULL); - SupportBitMask =3D (UINT8 *) PcdGetPtr (PcdCpuFeaturesSupport); =20 return SupportBitMask; } @@ -85,9 +84,8 @@ GetConfigurationPcds ( UINT8 *SupportBitMask; =20 BitMaskSize =3D PcdGetSize (PcdCpuFeaturesUserConfiguration); - SupportBitMask =3D AllocateZeroPool (BitMaskSize); + SupportBitMask =3D AllocateCopyPool (BitMaskSize, (UINT8 *) PcdGetPtr (P= cdCpuFeaturesUserConfiguration)); ASSERT (SupportBitMask !=3D NULL); - SupportBitMask =3D (UINT8 *) PcdGetPtr (PcdCpuFeaturesUserConfiguration); =20 return SupportBitMask; } --=20 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel