1. Patchew
  2. EDK2
  3. View series

[edk2] [PATCH V2] MdePkg ACPI: Incorrect definition name for ACPI IORT Table signature

Star Zeng posted 1 patch 7 years, 2 months ago
Failed in applying to current master (apply log)
MdePkg/Include/IndustryStandard/Acpi60.h | 6 +++---
MdePkg/Include/IndustryStandard/Acpi61.h | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
[edk2] [PATCH V2] MdePkg ACPI: Incorrect definition name for ACPI IORT Table signature
Posted by Star Zeng 7 years, 2 months ago 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=363

The definition name for ACPI IO Remapping Table signature is incorrect
in Acpi60.h and Acpi61.h as below:
EFI_ACPI_6_0_INTERRUPT_SOURCE_OVERRIDE_SIGNATURE
EFI_ACPI_6_1_INTERRUPT_SOURCE_OVERRIDE_SIGNATURE

The name should be changed to
EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE
EFI_ACPI_6_1_IO_REMAPPING_TABLE_SIGNATURE

The comments
///
/// "IORT" Interrupt Source Override
///
will be also changed to
///
/// "IORT" I/O Remapping Table
///

V2: Minor commit log update.

Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 MdePkg/Include/IndustryStandard/Acpi60.h | 6 +++---
 MdePkg/Include/IndustryStandard/Acpi61.h | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include/IndustryStandard/Acpi60.h
index ab798e9cf4c1..6183d8a9bd6c 100644
--- a/MdePkg/Include/IndustryStandard/Acpi60.h
+++ b/MdePkg/Include/IndustryStandard/Acpi60.h
@@ -1,7 +1,7 @@
 /** @file   
   ACPI 6.0 definitions from the ACPI Specification Revision 6.0 Errata A January, 2016.
 
-  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
   This program and the accompanying materials                          
   are licensed and made available under the terms and conditions of the BSD License         
@@ -2252,9 +2252,9 @@ typedef struct {
 #define EFI_ACPI_6_0_ISCSI_BOOT_FIRMWARE_TABLE_SIGNATURE  SIGNATURE_32('i', 'B', 'F', 'T')
 
 ///
-/// "IORT" Interrupt Source Override
+/// "IORT" I/O Remapping Table
 ///
-#define EFI_ACPI_6_0_INTERRUPT_SOURCE_OVERRIDE_SIGNATURE  SIGNATURE_32('I', 'O', 'R', 'T')
+#define EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE  SIGNATURE_32('I', 'O', 'R', 'T')
 
 ///
 /// "IVRS" I/O Virtualization Reporting Structure
diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h
index dc3153b7e7c8..0fac9a80694d 100644
--- a/MdePkg/Include/IndustryStandard/Acpi61.h
+++ b/MdePkg/Include/IndustryStandard/Acpi61.h
@@ -1,7 +1,7 @@
 /** @file   
   ACPI 6.1 definitions from the ACPI Specification Revision 6.1 January, 2016.
 
-  Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
  (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
   This program and the accompanying materials                          
   are licensed and made available under the terms and conditions of the BSD License         
@@ -2284,9 +2284,9 @@ typedef struct {
 #define EFI_ACPI_6_1_ISCSI_BOOT_FIRMWARE_TABLE_SIGNATURE  SIGNATURE_32('i', 'B', 'F', 'T')
 
 ///
-/// "IORT" Interrupt Source Override
+/// "IORT" I/O Remapping Table
 ///
-#define EFI_ACPI_6_1_INTERRUPT_SOURCE_OVERRIDE_SIGNATURE  SIGNATURE_32('I', 'O', 'R', 'T')
+#define EFI_ACPI_6_1_IO_REMAPPING_TABLE_SIGNATURE  SIGNATURE_32('I', 'O', 'R', 'T')
 
 ///
 /// "IVRS" I/O Virtualization Reporting Structure
-- 
2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH V2] MdePkg ACPI: Incorrect definition name for ACPI IORT Table signature
Posted by Yao, Jiewen 7 years, 2 months ago 
Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Zeng, Star
> Sent: Thursday, February 9, 2017 11:41 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Alexei Fedorov
> <Alexei.Fedorov@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH V2] MdePkg ACPI: Incorrect definition name for ACPI IORT Table
> signature
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=363
> 
> The definition name for ACPI IO Remapping Table signature is incorrect
> in Acpi60.h and Acpi61.h as below:
> EFI_ACPI_6_0_INTERRUPT_SOURCE_OVERRIDE_SIGNATURE
> EFI_ACPI_6_1_INTERRUPT_SOURCE_OVERRIDE_SIGNATURE
> 
> The name should be changed to
> EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE
> EFI_ACPI_6_1_IO_REMAPPING_TABLE_SIGNATURE
> 
> The comments
> ///
> /// "IORT" Interrupt Source Override
> ///
> will be also changed to
> ///
> /// "IORT" I/O Remapping Table
> ///
> 
> V2: Minor commit log update.
> 
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi60.h | 6 +++---
>  MdePkg/Include/IndustryStandard/Acpi61.h | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h
> b/MdePkg/Include/IndustryStandard/Acpi60.h
> index ab798e9cf4c1..6183d8a9bd6c 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi60.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi60.h
> @@ -1,7 +1,7 @@
>  /** @file
>    ACPI 6.0 definitions from the ACPI Specification Revision 6.0 Errata A January,
> 2016.
> 
> -  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
>    (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
> @@ -2252,9 +2252,9 @@ typedef struct {
>  #define EFI_ACPI_6_0_ISCSI_BOOT_FIRMWARE_TABLE_SIGNATURE
> SIGNATURE_32('i', 'B', 'F', 'T')
> 
>  ///
> -/// "IORT" Interrupt Source Override
> +/// "IORT" I/O Remapping Table
>  ///
> -#define EFI_ACPI_6_0_INTERRUPT_SOURCE_OVERRIDE_SIGNATURE
> SIGNATURE_32('I', 'O', 'R', 'T')
> +#define EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE
> SIGNATURE_32('I', 'O', 'R', 'T')
> 
>  ///
>  /// "IVRS" I/O Virtualization Reporting Structure
> diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h
> b/MdePkg/Include/IndustryStandard/Acpi61.h
> index dc3153b7e7c8..0fac9a80694d 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi61.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi61.h
> @@ -1,7 +1,7 @@
>  /** @file
>    ACPI 6.1 definitions from the ACPI Specification Revision 6.1 January, 2016.
> 
> -  Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
>   (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
> @@ -2284,9 +2284,9 @@ typedef struct {
>  #define EFI_ACPI_6_1_ISCSI_BOOT_FIRMWARE_TABLE_SIGNATURE
> SIGNATURE_32('i', 'B', 'F', 'T')
> 
>  ///
> -/// "IORT" Interrupt Source Override
> +/// "IORT" I/O Remapping Table
>  ///
> -#define EFI_ACPI_6_1_INTERRUPT_SOURCE_OVERRIDE_SIGNATURE
> SIGNATURE_32('I', 'O', 'R', 'T')
> +#define EFI_ACPI_6_1_IO_REMAPPING_TABLE_SIGNATURE
> SIGNATURE_32('I', 'O', 'R', 'T')
> 
>  ///
>  /// "IVRS" I/O Virtualization Reporting Structure
> --
> 2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.