.../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++++++ 1 file changed, 8 insertions(+)
ResetSystem runtime call allows for sending reset data that
starts with a NULL terminated string. Add support to print
that string on console.
Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
---
.../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
index 42f1b1d015..72bb1d2be6 100644
--- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
+++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
@@ -252,6 +252,14 @@ RuntimeServiceResetSystem (
mResetNotifyDepth
));
+ if ((ResetData != NULL) && (DataSize != 0)) {
+ DEBUG ((
+ DEBUG_INFO,
+ "DXE ResetSystem2: ResetData: %s\n",
+ ResetData
+ ));
+ }
+
if (mResetNotifyDepth <= MAX_RESET_NOTIFY_DEPTH) {
if (!EfiAtRuntime ()) {
//
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112145): https://edk2.groups.io/g/devel/message/112145
Mute This Topic: https://groups.io/mt/103025596/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Hello Gao, Checking if you have any feedback on this. Thanks Ashish ________________________________ From: Ashish Singhal <ashishsingha@nvidia.com> Sent: Wednesday, December 6, 2023 5:21 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen <jbrasen@nvidia.com> Cc: Ashish Singhal <ashishsingha@nvidia.com> Subject: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data ResetSystem runtime call allows for sending reset data that starts with a NULL terminated string. Add support to print that string on console. Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com> --- .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c index 42f1b1d015..72bb1d2be6 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c @@ -252,6 +252,14 @@ RuntimeServiceResetSystem ( mResetNotifyDepth )); + if ((ResetData != NULL) && (DataSize != 0)) { + DEBUG (( + DEBUG_INFO, + "DXE ResetSystem2: ResetData: %s\n", + ResetData + )); + } + if (mResetNotifyDepth <= MAX_RESET_NOTIFY_DEPTH) { if (!EfiAtRuntime ()) { // -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112564): https://edk2.groups.io/g/devel/message/112564 Mute This Topic: https://groups.io/mt/103025596/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hello, Checking again for some feedback on this. Thanks Ashish ________________________________ From: Ashish Singhal <ashishsingha@nvidia.com> Sent: Thursday, December 14, 2023 4:30 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen <jbrasen@nvidia.com> Subject: Re: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data Hello Gao, Checking if you have any feedback on this. Thanks Ashish ________________________________ From: Ashish Singhal <ashishsingha@nvidia.com> Sent: Wednesday, December 6, 2023 5:21 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen <jbrasen@nvidia.com> Cc: Ashish Singhal <ashishsingha@nvidia.com> Subject: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data ResetSystem runtime call allows for sending reset data that starts with a NULL terminated string. Add support to print that string on console. Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com> --- .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c index 42f1b1d015..72bb1d2be6 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c @@ -252,6 +252,14 @@ RuntimeServiceResetSystem ( mResetNotifyDepth )); + if ((ResetData != NULL) && (DataSize != 0)) { + DEBUG (( + DEBUG_INFO, + "DXE ResetSystem2: ResetData: %s\n", + ResetData + )); + } + if (mResetNotifyDepth <= MAX_RESET_NOTIFY_DEPTH) { if (!EfiAtRuntime ()) { // -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113012): https://edk2.groups.io/g/devel/message/113012 Mute This Topic: https://groups.io/mt/103025596/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Adding tianocore stewards to see if we can get some traction on this. ________________________________ From: Ashish Singhal <ashishsingha@nvidia.com> Sent: Monday, January 1, 2024 10:17 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen <jbrasen@nvidia.com> Subject: Re: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data Hello, Checking again for some feedback on this. Thanks Ashish ________________________________ From: Ashish Singhal <ashishsingha@nvidia.com> Sent: Thursday, December 14, 2023 4:30 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen <jbrasen@nvidia.com> Subject: Re: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data Hello Gao, Checking if you have any feedback on this. Thanks Ashish ________________________________ From: Ashish Singhal <ashishsingha@nvidia.com> Sent: Wednesday, December 6, 2023 5:21 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen <jbrasen@nvidia.com> Cc: Ashish Singhal <ashishsingha@nvidia.com> Subject: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data ResetSystem runtime call allows for sending reset data that starts with a NULL terminated string. Add support to print that string on console. Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com> --- .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c index 42f1b1d015..72bb1d2be6 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c @@ -252,6 +252,14 @@ RuntimeServiceResetSystem ( mResetNotifyDepth )); + if ((ResetData != NULL) && (DataSize != 0)) { + DEBUG (( + DEBUG_INFO, + "DXE ResetSystem2: ResetData: %s\n", + ResetData + )); + } + if (mResetNotifyDepth <= MAX_RESET_NOTIFY_DEPTH) { if (!EfiAtRuntime ()) { // -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114092): https://edk2.groups.io/g/devel/message/114092 Mute This Topic: https://groups.io/mt/103025596/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Ashish, On 2024-01-19 18:09, Ashish Singhal via groups.io wrote: > Adding tianocore stewards to see if we can get some traction on this. You've not cc:d Zhichao - who maintains that component - on this patch, I've added them. Please use BaseTools/Scripts/GetMaintainer.py to see who to cc - maintainership of some of the modules are split in multiple dimensions and it's basically impossible to work out manually. / Leif > ------------------------------------------------------------------------ > *From:* Ashish Singhal <ashishsingha@nvidia.com> > *Sent:* Wednesday, December 6, 2023 5:21 PM > *To:* devel@edk2.groups.io <devel@edk2.groups.io>; > gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen > <jbrasen@nvidia.com> > *Cc:* Ashish Singhal <ashishsingha@nvidia.com> > *Subject:* [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data > ResetSystem runtime call allows for sending reset data that > starts with a NULL terminated string. Add support to print > that string on console. > > Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com> > --- > .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > index 42f1b1d015..72bb1d2be6 100644 > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > @@ -252,6 +252,14 @@ RuntimeServiceResetSystem ( > mResetNotifyDepth > )); > > + if ((ResetData != NULL) && (DataSize != 0)) { > + DEBUG (( > + DEBUG_INFO, > + "DXE ResetSystem2: ResetData: %s\n", > + ResetData > + )); > + } > + > if (mResetNotifyDepth <= MAX_RESET_NOTIFY_DEPTH) { > if (!EfiAtRuntime ()) { > // > -- > 2.17.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114093): https://edk2.groups.io/g/devel/message/114093 Mute This Topic: https://groups.io/mt/103025596/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Thanks, Zhichao > -----Original Message----- > From: Leif Lindholm <quic_llindhol@quicinc.com> > Sent: Saturday, January 20, 2024 2:38 AM > To: devel@edk2.groups.io; ashishsingha@nvidia.com; > gaoliming@byosoft.com.cn; Jeff Brasen <jbrasen@nvidia.com>; Kinney, > Michael D <michael.d.kinney@intel.com>; afish@apple.com; Gao, Zhichao > <zhichao.gao@intel.com> > Subject: Re: [edk2-devel] [PATCH] > MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data > > Hi Ashish, > > On 2024-01-19 18:09, Ashish Singhal via groups.io wrote: > > Adding tianocore stewards to see if we can get some traction on this. > > You've not cc:d Zhichao - who maintains that component - on this patch, I've > added them. > > Please use BaseTools/Scripts/GetMaintainer.py to see who to cc - > maintainership of some of the modules are split in multiple dimensions and > it's basically impossible to work out manually. > > / > Leif > > > ------------------------------------------------------------------------ > > *From:* Ashish Singhal <ashishsingha@nvidia.com> > > *Sent:* Wednesday, December 6, 2023 5:21 PM > > *To:* devel@edk2.groups.io <devel@edk2.groups.io>; > > gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen > > <jbrasen@nvidia.com> > > *Cc:* Ashish Singhal <ashishsingha@nvidia.com> > > *Subject:* [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset > Data > > ResetSystem runtime call allows for sending reset data that > > starts with a NULL terminated string. Add support to print > > that string on console. > > > > Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com> > > --- > > .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git > a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > index 42f1b1d015..72bb1d2be6 100644 > > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > +++ > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > @@ -252,6 +252,14 @@ RuntimeServiceResetSystem ( > > mResetNotifyDepth > > )); > > > > + if ((ResetData != NULL) && (DataSize != 0)) { > > + DEBUG (( > > + DEBUG_INFO, > > + "DXE ResetSystem2: ResetData: %s\n", > > + ResetData > > + )); > > + } > > + > > if (mResetNotifyDepth <= MAX_RESET_NOTIFY_DEPTH) { > > if (!EfiAtRuntime ()) { > > // > > -- > > 2.17.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114126): https://edk2.groups.io/g/devel/message/114126 Mute This Topic: https://groups.io/mt/103025596/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks for the information Leif. Zhichao, I have created the PR https://github.com/tianocore/edk2/pull/5151 for this change and it has passed all tests. Please provide the push label. Thanks Ashish ________________________________ From: Gao, Zhichao <zhichao.gao@intel.com> Sent: Monday, January 22, 2024 7:01 AM To: Leif Lindholm <quic_llindhol@quicinc.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Ashish Singhal <ashishsingha@nvidia.com>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen <jbrasen@nvidia.com>; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com <afish@apple.com> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data External email: Use caution opening links or attachments Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Thanks, Zhichao > -----Original Message----- > From: Leif Lindholm <quic_llindhol@quicinc.com> > Sent: Saturday, January 20, 2024 2:38 AM > To: devel@edk2.groups.io; ashishsingha@nvidia.com; > gaoliming@byosoft.com.cn; Jeff Brasen <jbrasen@nvidia.com>; Kinney, > Michael D <michael.d.kinney@intel.com>; afish@apple.com; Gao, Zhichao > <zhichao.gao@intel.com> > Subject: Re: [edk2-devel] [PATCH] > MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data > > Hi Ashish, > > On 2024-01-19 18:09, Ashish Singhal via groups.io wrote: > > Adding tianocore stewards to see if we can get some traction on this. > > You've not cc:d Zhichao - who maintains that component - on this patch, I've > added them. > > Please use BaseTools/Scripts/GetMaintainer.py to see who to cc - > maintainership of some of the modules are split in multiple dimensions and > it's basically impossible to work out manually. > > / > Leif > > > ------------------------------------------------------------------------ > > *From:* Ashish Singhal <ashishsingha@nvidia.com> > > *Sent:* Wednesday, December 6, 2023 5:21 PM > > *To:* devel@edk2.groups.io <devel@edk2.groups.io>; > > gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen > > <jbrasen@nvidia.com> > > *Cc:* Ashish Singhal <ashishsingha@nvidia.com> > > *Subject:* [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset > Data > > ResetSystem runtime call allows for sending reset data that > > starts with a NULL terminated string. Add support to print > > that string on console. > > > > Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com> > > --- > > .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git > a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > index 42f1b1d015..72bb1d2be6 100644 > > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > +++ > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > @@ -252,6 +252,14 @@ RuntimeServiceResetSystem ( > > mResetNotifyDepth > > )); > > > > + if ((ResetData != NULL) && (DataSize != 0)) { > > + DEBUG (( > > + DEBUG_INFO, > > + "DXE ResetSystem2: ResetData: %s\n", > > + ResetData > > + )); > > + } > > + > > if (mResetNotifyDepth <= MAX_RESET_NOTIFY_DEPTH) { > > if (!EfiAtRuntime ()) { > > // > > -- > > 2.17.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114132): https://edk2.groups.io/g/devel/message/114132 Mute This Topic: https://groups.io/mt/103025596/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.