From nobody Wed May 15 15:12:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108150+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108150+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1693415473; cv=none; d=zohomail.com; s=zohoarc; b=ZIzZ+4tNGE3MlfLiy0Td9EOLoPi1OzO03Z06gScP4GFN7D76KHeIBcbY2EwFnasfjPhDTMZKHljiwBmTI3jGSXWXBx//LfTBxKIw415kGKCr+tJwLmI9yOtZQ7GlfuvGKQSNpy/3pXtLooA67oNEXpQnv5dIizntnbqWx7Bzs8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693415473; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=qlkL9DJNebzuUakfd6Iquzj5KAnNmrY7ioBMORBO4Vk=; b=G8zbD+hh53IX2vvnooWWm1/v5m/GpZYnDZLCacc3RhzNcsfmOxrpdMKZVvkKqRdaogS+H1bq/kjPNBc4KWjRkizTsYTbMAXHGjVZwyIcW5oE/pzBtjKlWmQUnbmwEZu60yUgQhtptUNDd6WhDRvxjYXRkHCK7x7BaRQlVnhdsks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108150+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1693415473840440.2321441541767; Wed, 30 Aug 2023 10:11:13 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=8KBSnd7CIAUhoQXcZjMPEjaASR9AA/W7al78TOXHcfE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693415473; v=1; b=JHYbRc3aqYgt6t5J8eNutoL7ii9SKaELdVEFMcPtJVqslZdRCJRCoe+CNpHl0v3BzJAOnmKn EDlpiY0s+RFhFz4OrZ6mrMBzzSAXhFA/Yiygrl0B60HCCwLTIY4qyLQt3+h9CYr+T2qbGTokq/T 7pe9ApWus15V7LMjj+b6rijk= X-Received: by 127.0.0.2 with SMTP id zpXTYY1788612x1mHqrT8CHJ; Wed, 30 Aug 2023 10:11:13 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.9944.1693386794127098112 for ; Wed, 30 Aug 2023 02:13:14 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="374499932" X-IronPort-AV: E=Sophos;i="6.02,213,1688454000"; d="scan'208";a="374499932" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 02:13:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="809057829" X-IronPort-AV: E=Sophos;i="6.02,213,1688454000"; d="scan'208";a="809057829" X-Received: from shserverbios518.ccr.corp.intel.com ([10.5.215.122]) by fmsmga004.fm.intel.com with ESMTP; 30 Aug 2023 02:13:11 -0700 From: horacex.lien@intel.com To: devel@edk2.groups.io Cc: HoraceX Lien , Zhiguang Liu , Dandan Bi , Star Zeng , Zhichao Gao Subject: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Date: Wed, 30 Aug 2023 17:12:44 +0800 Message-Id: <0439b4b435989b2604d325451ae0fa6b70bb0a20.1693386097.git.horacex.lien@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,horacex.lien@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fYOsCDJR91RHsPxjADnjyYoCx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1693415475881100003 Content-Type: text/plain; charset="utf-8" From: HoraceX Lien REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4544 These value of Major/Minor version are updated from SMBIOS memory data, but BCD Revision is updated from PCD PcdSmbiosVersion. We should also update PCD PcdSmbiosVersion from SMBIOS memory data, to ensure that get consistent version value. Cc: Zhiguang Liu Cc: Dandan Bi Cc: Star Zeng Cc: Zhichao Gao Signed-off-by: HoraceX Lien --- MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c b/MdeModulePkg/Un= iversal/SmbiosDxe/SmbiosDxe.c index 1a86e69d3c..e3f6215033 100644 --- a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c +++ b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c @@ -1072,7 +1072,7 @@ SmbiosCreateTable ( DEBUG ((DEBUG_INFO, "SmbiosCreateTable: Initialize 32-bit entry point = structure\n")); EntryPointStructureData.MajorVersion =3D mPrivateData.Smbios.Majo= rVersion; EntryPointStructureData.MinorVersion =3D mPrivateData.Smbios.Mino= rVersion; - EntryPointStructureData.SmbiosBcdRevision =3D (UINT8)((PcdGet16 (PcdSm= biosVersion) >> 4) & 0xf0) | (UINT8)(PcdGet16 (PcdSmbiosVersion) & 0x0f); + EntryPointStructureData.SmbiosBcdRevision =3D (mPrivateData.Smbios.Maj= orVersion << 4) | mPrivateData.Smbios.MinorVersion; PhysicalAddress =3D 0xffffffff; Status =3D gBS->AllocatePages ( AllocateMaxAddress, --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108150): https://edk2.groups.io/g/devel/message/108150 Mute This Topic: https://groups.io/mt/101057293/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-